search

NTNU-IndEcol / BuildME

6 stars 1 forks source link

Ffactor and Cfactor constructions cannot be subject to RES strategy #68

Closed nheeren closed 2 years ago

nheeren commented 2 years ago

I added a fix that should deal with the Ffactor and Cfactor constructions. Should be checked once more before merging into master's - I'm not sure how compatible the fix is with the changes that Sahin have been doing to the archetypes lastly :) But as far as my understanding goes - I think the new archetypes are implemented now!

Originally posted by @kamilitsa in https://github.com/nheeren/BuildME/issues/47#issuecomment-1092120438

Thank you again for coming up with this (i.e. add_underground_wall_cfactor() and add_ground_floor_ffactor())! However, I now realize this actually causes quite an issue that we hadn't considered.

The thicknesses for concrete are hard-coded, e.g. https://github.com/nheeren/BuildME/blob/39277676019e0aefe4deb6f37da278b1e6005e54/BuildME/idf.py#L479-L485

Thus we cannot manipulate them anymore with the res-replaceme string.

kamilakrych commented 2 years ago

Okay, I have an idea how to fix it. What would you suggest then as the RES2.1 and RES2.2 options? Let's remember that it's a foundation, so wood is not a good option. Maybe something like 15 cm concrete for RES0 and 10 cm concrete for all the other cases?

(On another note, I have impression that the options RES2.1 and RES2.1+RES2.2 are the same - based on simulation results and a brief look at the construction types)

nheeren commented 2 years ago

I would say the foundation is always concrete, regardless the RES. RES2.2 and RES2.1+RES2.2 can have 20% reduced concrete amount.

Yes, RES2.1 and RES2.1+RES2.2 are fairly similar. However, the latter should have less wood in some elements.

kamilakrych commented 2 years ago

Should be fixed now!

nheeren commented 2 years ago

Awesome! Thank you so much. That should solve it for now.

I made a little change, because in some IDFs I did not specify the RES.