search

NTNU-IndEcol / BuildME

6 stars 1 forks source link

DHW results are included in total energy intensity values #69

Closed shnkn closed 2 years ago

shnkn commented 2 years ago

Hello Niko,

I think there is something wrong with the energy intensity excel file produced after the simulations. The value generated in the "total" sheet seems like summing up MJ with m3. So externally defined DHW is added on top of the total energy consumption. Instead, this one should only take into consideration of MJs, right? I excluded this in my latest branch.

nheeren commented 2 years ago

Thanks for raising this! Can you specify where it goes wrong and how you fixed it?

shnkn commented 2 years ago

Sorry for my late reply, I was trying to calculate the DHW load dynamically from the IDFs if a DHW system is already modeled, otherwise, the code uses the as-is version with running the add_DHW() function. So, in order to do that, I inserted a new output variable ('WaterSystems: Water m3') while converting the IDFs. However, this variable calculates water consumption in m3 instead of the energy (MJ) required to heat water.

So in the final _ei.xlsx sheet, all loads from heating, cooling and DHW are summed and a new sheet called "total" is created normally. When I did the above changes the code summed MJ and m3 together so I thought maybe you were doing the same thing.

image

Here, users add the DHW load exogenously, I thought this was the volumetric water consumption in m3 but I guess you are adding the energy required to heat water and the unit is already in MJ here.

I just wanted to check this with you. I should find another output variable to get the energy for DHW instead of water consumption.

shnkn commented 2 years ago

Okay, I added a condition to detect if DHW is already modeled in IDF files. Instead of m3, I am collecting the energy required to heat the water now. In the final results, I am also including them in the sum as you have done it before. You can see the latest updates in my branch.

1 parent 0348e09 commit 7ed2beace45db71fb6947fbc7cd5379698970d80

nheeren commented 2 years ago

Thanks Sahin. I will look into it. We should discuss soon what is happening in your branch and how to get it back into the main branch. I fear you are creating an alternative version of BuildME on your branch and it will become hard to merge eventually.