search

NTStation / NTstation13

NTstation13 - A version of Spacestation13, forked from /tg/station13.
36 stars 199 forks source link

Cannot perform another surgery after completing eye surgery #224

Closed Iamgoofball closed 10 years ago

Iamgoofball commented 10 years ago

Issue by Tenebrosity from Wednesday Dec 18, 2013 at 10:55 GMT Originally opened as https://github.com/tgstation/-tg-station/issues/2065

I did eye surgery on an Assistant's eyes after they were blinded with a screwdriver. I even did the final step, cauterising the wound, even though it does nothing. For some reason the surgery only improved their vision slightly, so I placed them back on the operating table to perform it again. On help intent, I used the surgical drapes while still aimed at their eyes. I just slapped them in the head with the drapes repeatedly, thankfully doing no damage.

I hate to think this means that after eye surgery (or any surgery perhaps) that a person cannot receive any more surgery.

This brought to mind um, augmentations, which crew routinely get several of, so perhaps the issue is only with eye surgery, or maybe it had to do with me aiming at his eyes with the surgical drapes (I don't think it'd make a difference though).

Iamgoofball commented 10 years ago

Comment by RobRichards1997 from Wednesday Dec 18, 2013 at 11:37 GMT

Once a particular surgery is completed, it is removed from that person's surgery list, it is impossible without Var-editing to give them the surgery again at the present time. This is how it always has been, even before Augmentations, I'd label this as an Intended action, not a Bug as there is code specifically designed to remove the surgery afterward.

Iamgoofball commented 10 years ago

Comment by Giacom from Wednesday Dec 18, 2013 at 12:38 GMT

Was this always an issue, since surgery datums were created, or is this a recently new issue.

Iamgoofball commented 10 years ago

Comment by Razharas from Wednesday Dec 18, 2013 at 13:56 GMT

I really hope its not a feature

Iamgoofball commented 10 years ago

Comment by RobRichards1997 from Wednesday Dec 18, 2013 at 15:40 GMT

@Giacom It's intended in the code (This is in code/modules/surgery/surgery.dm and pre-dates Augmentation by a LONG time.)

/datum/surgery/proc/complete(mob/living/carbon/human/target)
    target.surgeries -= src
    src = null

Basically it isn't a Bug with the eye surgery, it's a Feature of all surgeries.

Iamgoofball commented 10 years ago

Comment by Giacom from Wednesday Dec 18, 2013 at 15:53 GMT

@Petethegoat: fix it u mothergoater

Iamgoofball commented 10 years ago

Comment by RobRichards1997 from Wednesday Dec 18, 2013 at 15:59 GMT

To be fair, out of what's been reported the only Bug here is no surgeries after the eye surgery, I assume the assistant did now have all other surgeries done on them (If they had Please mention it) The only way you end up with 0 surgeries is having had them all, or had some removed (such as the Robotic chest removing certain surgeries on the chest due to not ever needing those ops)

Iamgoofball commented 10 years ago

Comment by Tenebrosity from Thursday Dec 19, 2013 at 08:50 GMT

Once a particular surgery is completed, it is removed from that person's surgery list,

I guess I should've explained it more clearly. The issue was with me slapping them with the drapes instead of causing the surgery list to pop up. They hadn't had every other surgery performed because there were multiple surgeries on the list when I selected eye surgery the first time. Sometimes you need to perform multiple surgeries, as in this case, and in the event of multiple alien impregnations (believe it or not an HoS got impregnated three times one round).

Iamgoofball commented 10 years ago

Comment by RobRichards1997 from Thursday Dec 19, 2013 at 15:40 GMT

No you explained it quite well, the Only and I mean ONLY time you will slap someone with the drapes is when that person has an empty surgery list, Now you've stated he had plenty of operations left we can agree there is a bug that is emptying the surgeries list.

Iamgoofball commented 10 years ago

Comment by Petethegoat from Saturday Dec 21, 2013 at 11:01 GMT

the mob.surgeries list is for active surgeries that are currently being performed on the mob

Iamgoofball commented 10 years ago

Comment by KazeEspada from Saturday Dec 21, 2013 at 18:01 GMT

Can you initiate multiple surgerys at once? Or do you have to complete the previous surgery first.

Iamgoofball commented 10 years ago

Comment by RobRichards1997 from Saturday Dec 21, 2013 at 18:03 GMT

You can initiate as many as you choose.