Atmos chamber consoles are not borked anymore

[Iamgoofball]

Issue by Razharas from Thursday Feb 20, 2014 at 16:52 GMT Originally opened as https://github.com/tgstation/-tg-station/pull/2853

---

Now you can deconstruct/construct them without them borking forever To pick the chamber to controll click console with multitool and choose from popup Also code is closer to actual standarts now(not by much but still) fixes #2892

---

Razharas included the following code: https://github.com/tgstation/-tg-station/pull/2853/commits

[Iamgoofball]

Comment by Miauw62 from Thursday Feb 20, 2014 at 16:55 GMT

---

Nobody will ever figure out by themselves that they have to ctrl-click with a multitool.

On Thu, Feb 20, 2014 at 5:52 PM, Razharas notifications@github.com wrote:

Now you can deconstruct/construct them without them borking forever To pick the chamber to controll click console with multitool and choose

from popup

You can merge this Pull Request by running

git pull https://github.com/Razharas/-tg-station AtmosComputers

Or view, comment on, or merge it at:

https://github.com/tgstation/-tg-station/pull/2853 Commit Summary

• Atmos chamber consoles are not borked anymore

File Changes

• M code/game/machinery/atmo_control.dmhttps://github.com/tgstation/-tg-station/pull/2853/files#diff-0(615)
• M code/game/machinery/computer/buildandrepair.dmhttps://github.com/tgstation/-tg-station/pull/2853/files#diff-1(4)

Patch Links:

• https://github.com/tgstation/-tg-station/pull/2853.patch
• https://github.com/tgstation/-tg-station/pull/2853.diff

Reply to this email directly or view it on GitHubhttps://github.com/tgstation/-tg-station/pull/2853 .

[Iamgoofball]

Comment by Petethegoat from Thursday Feb 20, 2014 at 16:57 GMT

---

I don't think that's what he means, Miauw

[Iamgoofball]

Comment by Miauw62 from Thursday Feb 20, 2014 at 16:58 GMT

---

Oh, whoops

On Thu, Feb 20, 2014 at 5:57 PM, Pete Goodfellow notifications@github.comwrote:

I don't think that's what he means, Miauw

Reply to this email directly or view it on GitHubhttps://github.com/tgstation/-tg-station/pull/2853#issuecomment-35643170 .

[Iamgoofball]

Comment by Razharas from Thursday Feb 20, 2014 at 16:58 GMT

---

Excuse english bad

[Iamgoofball]

Comment by Razharas from Thursday Feb 20, 2014 at 16:59 GMT

---

Also i know the way it is done is rather bad but i couldnt make unary injectors use generic var since it is set on the map and you would need to change the map for it to work

[Iamgoofball]

Comment by Intigracy from Tuesday Feb 25, 2014 at 06:15 GMT

---

Put fixes #2892 somewhere so it autocloses on merge.

[Iamgoofball]

Comment by Aranclanos from Tuesday Feb 25, 2014 at 14:12 GMT

---

ahhhhhhhhh at roundstart there are a million of runtimes

[Iamgoofball]

Comment by Aranclanos from Tuesday Feb 25, 2014 at 14:15 GMT

---

runtime error: Cannot execute null.remove object().
proc name: set frequency (/obj/machinery/computer/general_air_control/proc/set_frequency)
  source file: atmo_control.dm,156
  usr: null
  src: Nitrogen Supply Control (/obj/machinery/computer/general_air_control/large_tank_control)
  call stack:
Nitrogen Supply Control (/obj/machinery/computer/general_air_control/large_tank_control): set frequency(1441)
Nitrogen Supply Control (/obj/machinery/computer/general_air_control/large_tank_control): New(the floor (127,83,1) (/turf/simulated/floor))
runtime error: Cannot execute null.remove object().
proc name: set frequency (/obj/machinery/computer/general_air_control/proc/set_frequency)
  source file: atmo_control.dm,156
  usr: null
  src: Oxygen Supply Control (/obj/machinery/computer/general_air_control/large_tank_control)
  call stack:
Oxygen Supply Control (/obj/machinery/computer/general_air_control/large_tank_control): set frequency(1441)
Oxygen Supply Control (/obj/machinery/computer/general_air_control/large_tank_control): New(the floor (131,83,1) (/turf/simulated/floor))
runtime error: Cannot execute null.remove object().
proc name: set frequency (/obj/machinery/computer/general_air_control/proc/set_frequency)
  source file: atmo_control.dm,156
  usr: null
  src: Mixed Air Supply Control (/obj/machinery/computer/general_air_control/large_tank_control)
  call stack:
Mixed Air Supply Control (/obj/machinery/computer/general_air_control/large_tank_control): set frequency(1443)
Mixed Air Supply Control (/obj/machinery/computer/general_air_control/large_tank_control): New(the floor (135,83,1) (/turf/simulated/floor))
runtime error: Cannot execute null.remove object().
proc name: set frequency (/obj/machinery/computer/general_air_control/proc/set_frequency)
  source file: atmo_control.dm,156
  usr: null
  src: Carbon Dioxide Supply Control (/obj/machinery/computer/general_air_control/large_tank_control)
  call stack:
Carbon Dioxide Supply Control (/obj/machinery/computer/general_air_control/large_tank_control): set frequency(1441)
Carbon Dioxide Supply Control (/obj/machinery/computer/general_air_control/large_tank_control): New(the floor (136,87,1) (/turf/simulated/floor))
runtime error: Cannot execute null.remove object().
proc name: set frequency (/obj/machinery/computer/general_air_control/proc/set_frequency)
  source file: atmo_control.dm,156
  usr: null
  src: Toxin Supply Control (/obj/machinery/computer/general_air_control/large_tank_control)
  call stack:
Toxin Supply Control (/obj/machinery/computer/general_air_control/large_tank_control): set frequency(1441)
Toxin Supply Control (/obj/machinery/computer/general_air_control/large_tank_control): New(the floor (136,91,1) (/turf/simulated/floor))
runtime error: Cannot execute null.remove object().
proc name: set frequency (/obj/machinery/computer/general_air_control/proc/set_frequency)
  source file: atmo_control.dm,156
  usr: null
  src: Nitrous Oxide Supply Control (/obj/machinery/computer/general_air_control/large_tank_control)
  call stack:
Nitrous Oxide Supply Control (/obj/machinery/computer/general_air_control/large_tank_control): set frequency(1441)
Nitrous Oxide Supply Control (/obj/machinery/computer/general_air_control/large_tank_control): New(the floor (136,95,1) (/turf/simulated/floor))
runtime error: Cannot execute null.remove object().
proc name: set frequency (/obj/machinery/computer/general_air_control/proc/set_frequency)
  source file: atmo_control.dm,156
  usr: null
  src: Gas Mix Tank Control (/obj/machinery/computer/general_air_control/large_tank_control)
  call stack:
Gas Mix Tank Control (/obj/machinery/computer/general_air_control/large_tank_control): set frequency(1441)
Gas Mix Tank Control (/obj/machinery/computer/general_air_control/large_tank_control): New(the floor (136,99,1) (/turf/simulated/floor))

[Iamgoofball]

Comment by Razharas from Tuesday Feb 25, 2014 at 14:27 GMT

---

Interesting

[Iamgoofball]

Comment by Razharas from Tuesday Feb 25, 2014 at 14:53 GMT

---

It doesnt runtime to me, but ill fix the possible cause of this

[Iamgoofball]

Comment by Aranclanos from Wednesday Feb 26, 2014 at 09:24 GMT

---

Doesn't seem to work. and the multitool use, besides runtiming to hell, is not standard at all, nobody will ever know that it's a thing, specially when you already have live href buttons to search for an input and output. Those need to be fixed.

[Iamgoofball]

Comment by Razharas from Wednesday Feb 26, 2014 at 14:25 GMT

---

Can add button, but multitool doesnt runtime to me again

[Iamgoofball]

Comment by Razharas from Sunday Mar 02, 2014 at 22:10 GMT

---

Aran plz check 'em //

[Iamgoofball]

Comment by Aranclanos from Thursday Mar 06, 2014 at 00:44 GMT

---

doesn't work properly, the "sensor data" doesn't seem to reconnect

[Iamgoofball]

Comment by Aranclanos from Thursday Mar 06, 2014 at 00:44 GMT

---

razh you keep insisting me to merge these two PRs but they are always broken cmon

[Iamgoofball]

Comment by Razharas from Thursday Mar 06, 2014 at 01:03 GMT

---

Whats broken in them? I dont get any rumtimes, i dunno what to fix

[Iamgoofball]

Comment by Razharas from Saturday Mar 08, 2014 at 23:23 GMT

---

Ok i discovered some insanity in atmos computers, the fix will come later

[Iamgoofball]

Comment by Aranclanos from Sunday Mar 09, 2014 at 02:36 GMT

---

hah