search

NTStation / NTstation13

NTstation13 - A version of Spacestation13, forked from /tg/station13.
36 stars 199 forks source link

Ninja code #50

Closed Iamgoofball closed 10 years ago

Iamgoofball commented 10 years ago

Issue by Petethegoat from Thursday Apr 18, 2013 at 13:03 GMT Originally opened as https://github.com/tgstation/-tg-station/issues/402

Ninja code badly needs recoding. Here is a list of the main features: http://pastebin.com/Apk4b6Ru

Iamgoofball commented 10 years ago

Comment by KazeEspada from Thursday Apr 18, 2013 at 19:41 GMT

I have successfully removed all ninja code from my code, and it has not produced runtimes. Should I make a pull request?

Iamgoofball commented 10 years ago

Comment by Aranclanos from Thursday Apr 18, 2013 at 22:47 GMT

it needs recoding, not removing

Iamgoofball commented 10 years ago

Comment by KazeEspada from Thursday Apr 18, 2013 at 22:51 GMT

recoding is harder than removing and reimplementing.

Iamgoofball commented 10 years ago

Comment by Nodrak from Thursday Apr 18, 2013 at 23:08 GMT

Normally I'd agree with you Aran, but in the case of ninja's, I think completely erasing it and recoding it from scratch would be the best way to go. I can't think of a single instance of ninja code that I'd want salvaged since most of it could be condensed into half as many lines of code.

Iamgoofball commented 10 years ago

Comment by KazeEspada from Thursday Apr 18, 2013 at 23:49 GMT

capture code, i kept that, cause i liked it.

Iamgoofball commented 10 years ago

Comment by Aranclanos from Friday Apr 19, 2013 at 00:59 GMT

I'm fine with recoding it from scratch, but a pull request only removing ninjas it's not going to be merged by me

Iamgoofball commented 10 years ago

Comment by Petethegoat from Friday Apr 19, 2013 at 01:01 GMT

I'd be up for having a ninja branch, so we can collab on the replacements. Code a power each until it's more or less back. Something like that.

Iamgoofball commented 10 years ago

Comment by KazeEspada from Friday Apr 19, 2013 at 17:59 GMT

so should I put up the ninja clean code?

Iamgoofball commented 10 years ago

Comment by Carn from Saturday Apr 20, 2013 at 18:20 GMT

I hate you all. I recoded most of it already. All you have to do is fix the the equipment. I feel so appreciated.

Iamgoofball commented 10 years ago

Comment by KazeEspada from Wednesday Sep 18, 2013 at 01:56 GMT

with the pull of sayus click change and the addition of the glove proc Touch(). Ninja code is now centralized into files. I think this can be closed.

Iamgoofball commented 10 years ago

Comment by MrPerson from Wednesday Sep 18, 2013 at 02:25 GMT

Only if there's no more colon operators.

Iamgoofball commented 10 years ago

Comment by Aranclanos from Wednesday Sep 18, 2013 at 02:30 GMT

are