NTStation / NTstation13

NTstation13 - A version of Spacestation13, forked from /tg/station13.
36 stars 198 forks source link

Attempting to install an APC on the asteroid can lock up the server. #895

Open GunHog opened 10 years ago

GunHog commented 10 years ago

Problem Description: What is the problem? It is possible lag out the server by installing an APC on the asteroid, away from the outposts.

What did you expect to happen: I expected the APC to attach to the wall instantly, ready for finishing.

Why do you think this is a bug? Because it creates lag so extreme that it brings down the entire server.

What happened instead: Attempting to place the APC frame onto the wall immediately locked up the entire server for a few minutes. The server later returned, the APC frame placed onto the wall.

How is what happened different from what you expected? It should not have locked up the server.

Why is this bad/What are the consequences: It locks up the server, preventing anyone being able to continue the round for quite a while.

Why do you think this is an important issue? It is a critical issue, as the potential for abuse is extreme.

Steps to reproduce the problem: Go to the mining asteroid, and build a metal wall anywhere deep into the rock. Create an APC frame from metal, then attempt to attach it to the wall. You must be in an area where minerals can spawn. You may need to dig a little.

Server: Which server were you playing on? Artyom.

Revision: What revision was the server running? Type 'show-server-revision' ingame to find out. 2014-07-28 35aab236097e1ff98c4585b3eedb595cc3339d10

Possibly related stuff: The asteroid map is composed of very large areas (I am talking about how the game's map file defines an "area"). The lag is likely due to the game attempting to determine how much of the asteroid area the APC itself will power. Due to the asteroid having very HUGE areas, this check is time-consuming and resource intensive, so much so that it will halt the game in order to complete it. That is my theory, anyway.

Bawhoppen commented 9 years ago

I think that it just happens for any APC you try to attach since this happened to me one round where we were renovating the moon outpost and the server tempcrashed when I tried to put down an APC

GunHog commented 9 years ago

It is due to area size. Big defined areas means the game takes forever to figure out what the APC is supposed to power.