NTUT-FUCK-PTSD / Fuck-PTSD

This is a repo about rewriting the game `crypt of the necrodancer` in OOP Lab
MIT License
2 stars 2 forks source link

[WIP] Dungeon::enemies Map Collision between Enemy and Tile #52

Closed HeavenManySugar closed 5 months ago

HeavenManySugar commented 5 months ago

This pull request includes the following changes:

onon1101 commented 5 months ago

i will review later.

onon1101 commented 5 months ago

you use the multiple inheritance, it maybe more complexity of the architecture in your Dungeon. and if you don't use the keywork final. it will happen that Diamond Problem if inheritance the Enemies ......

class Bat : public Dungeon::Enemy, public Animation {

i recommend to use the interface to make the class of Enemies, like this T-word means Type of something that it all of method are pure virtual function.

class Bat final : public Dungeon::TEnemy, public TAnimation {
public;
void move override () 
}