Offering several optimizations and fixes

NU-ITS / LAPSforMac

Local Administrator Password Solution for Mac

MIT License

139 stars 42 forks source link

Offering several optimizations and fixes #5

Closed taylor-madeak closed 7 years ago

taylor-madeak commented 7 years ago

The primary focus of this pull request is twofold:

1 - Protect the LAPS password from exposure to any users lurking on SSH. 2 - Bring the language a little closer to BASH standardization with things like $() command execution syntax and quotes to prevent globbing and splitting.

For this request, I am focusing on LAPS Account Creation.sh only.

taylor-madeak commented 7 years ago

Several of the double-quoted strings in this cause the script to break. I will offer a working alternative soon.