search

NUARIG / competitions

Competitions is a platform to support robust peer review within and across CTSA hubs. This is a cloud-based, single-sign on application for investigators, reviewers and administrators. With Competitions, you can post opportunities, submit applications and review and score those submissions
MIT License
1 stars 1 forks source link

Task/fix grant redirect on slug change #1056

Closed jseraf closed 4 months ago

jseraf commented 4 months ago

Closes #1051

Fixes redirect on change to the grant's friendly URL.

lmkw commented 4 months ago

i put in a short name that violated rules (had a character, !, that's not allowed) and when i clicked Update it gave me an error (expected behavior). then i went back and changed the short name to something that was acceptable but when i clicked Update another time, it gave me the same error and in the URL i could see it was using the incorrect short name (the one with the !). then i tried it again, editing the short name to the same acceptable one, and it finally "took".

error message i got when short name was: https://[host[/grants/againagain! The page you were looking for doesn't exist.

You may have mistyped the address or the page may have moved.

[Visit the homepage to see a list of current grants.]

jseraf commented 4 months ago

I think this is due to https://github.com/norman/friendly_id/issues/1012