Formalize behavior of authority interface's find_users method when there are zero criteria

NUBIC / aker

A flexible security framework for Rack (and Rails) apps. Good for integration with legacy systems, CAS SSO (including proxying), machine and interactive authentication, and much more.

MIT License

1 stars 2 forks source link

Formalize behavior of authority interface's find_users method when there are zero criteria #26

Open rsutphin opened 11 years ago

rsutphin commented 11 years ago

The documentation for CompositeAuthority#find_users does not specify what the behavior should be when the *criteria parameter resolves to an empty array.

The Static authority returns zero users when there are no criteria. LDAP::Authority appears to also, though I'm less sure without writing a test. It seems reasonable to make this the documented behavior for #find_users.

rsutphin commented 11 years ago

This was brought up in NUBIC/ncs_navigator_authority#4.