NUDelta / orchestration-engine

Scripts to guide situated actions, powered by programming constructs that model ways of working
0 stars 0 forks source link

Rounding feedback opportunity timestamp #14

Closed kapil1garg closed 2 years ago

kapil1garg commented 2 years ago

This PR introduces a bugfix for an issue where, on the server, feedback opportunities would not execute because the timestamp had a small amount of variance in seconds and the engine expected the timestamp to be an exact match (e.g., a script should trigger at studio on 04-08-22 13:00:00 but the timestamp for the script's actionable feedback is 04-08-22 13:00:04, which would not exact match). The current fix involves flooring the feedback opportunity's timestamp to the nearest 5 mins, which works for now but there might be more robust ways to handle this issue (see #13).

This PR also updates the simulation code for testing locally, where now a small amount of jitter to the system clock is added throughout the simulation. This more closely mimics how the code would execute on the server where, due to execution time, some parts of the code would not execute--for example--every 30 mins on the dot.