search

NUKnightLab / StoryMapJS

Maps that tell stories.
https://storymap.knightlab.com/
Other
183 stars 50 forks source link

Chrome console error message #468

Closed michelemazzali closed 11 months ago

michelemazzali commented 3 years ago

Hi, https://myportheritage.eu/exhibitions/ravenna-flux-of-people/ Chrome console fires an error Uncaught TypeError: Cannot read property 'length' of undefined firing at line 213 of StoryMap.js

        // Emoji Support to Chrome?
        if (Browser.chrome) {
            loadCSS(urljoin(this.options.script_path,"../css/fonts/font.emoji.css"), function() {
            });
        }

thus impeding other js instructions to be executed (namely, a custom function which scrolls the div to another language). Thanks!

michelemazzali commented 3 years ago

Update: I had to switch back to version 0.7.6 to make it work

scott2b commented 3 years ago

font.emoji.css is in the latest code in the CDN, so it is hard to know what is causing this error without seeing the code in it's broken state. The font file is loaded relative to what is determined to be the script path by the getScriptPath call in the buildStoryMap function. So, if you have a script tag on the page that interferes with the heuristics of that function (it uses an expression match to the script source reference) this could be one cause for this error, and one way I was able to replicate the error. Be sure your script tags are pointing to the CDN, or if you are hosting your own copy of the code, then you will also need to host relative assets like the emoji font file.

I have attached below a test.html which exemplifies creating a StoryMap page using the data from your StoryMap with the hope that you might be able to determine difference / potential conflicts with your own code that resulted in the error.

test.html.gz

JoeGermuska commented 11 months ago

fixed in 0.9.4 released today