search

NUKnightLab / TimelineJS-Wordpress-Plugin

A simple shortcode plugin to add the Timeline to Wordpress
Other
207 stars 50 forks source link

[Feature Request] Add prefix to classes #12

Closed quantizor closed 12 years ago

quantizor commented 12 years ago

General feature request...

The classes used in building the timeline are too common... there's a high risk of collision with general theme classes which can then screw up the rendering and layout. I recommend adding a "timeline-" or "vct-" prefix to them to avoid this issue.

zachwise commented 12 years ago

All of the classes are scoped to #timeline

quantizor commented 12 years ago

Yeah, but if they are generally-used class names, then unless you've declared every possible CSS value for it, scoping it to an ID doesn't matter.

For instance, many boilerplate themes use .container for wrapping the content and commonly have padding attached to them. The CSS file included in the plugin does not contain sufficient padding declarations to reset the element for desired viewing. It's just not good CSS practice.

zachwise commented 12 years ago

This issue belongs under the Timeline repo not the Wordpress one: https://github.com/VeriteCo/Timeline/issues

I'm adding more class names to the reset for common names

quantizor commented 12 years ago

Will do, thanks Zach!

zachwise commented 12 years ago

Addressed in the latest commit on the main Timeline repo eacedbf728e9f3265b866da169872d0dd4c85a21