search

NUKnightLab / TimelineJS3

TimelineJS v3: A Storytelling Timeline built in JavaScript. http://timeline.knightlab.com
Mozilla Public License 2.0
2.97k stars 619 forks source link

support HTML5 audio/video tags #228

Open JoeGermuska opened 9 years ago

JoeGermuska commented 9 years ago

Zach:

It seems functionally easy to support audio and video tags using the iframe media type.

Would you be cool with adding that to the pattern for that media type? Do you think some other presentation/styling is necessary? Is it worth adding a new media type just to support a different CSS class other than tl-media-iframe ?

JoeGermuska commented 9 years ago

Conversation with @zachwise indicated that this would need custom markup to work right, rather than simply using the TL.Media.IFrame class. We'll consider it in the future.

quinn commented 8 years ago

@JoeGermuska @zachwise in the same way that an <img> tag is used based on the extension, couldn't the same thing be done for video extensions?