search

NUKnightLab / TimelineJS3

TimelineJS v3: A Storytelling Timeline built in JavaScript. http://timeline.knightlab.com
Mozilla Public License 2.0
2.97k stars 622 forks source link

Hash/bookmarks don't work with iframes #293

Open JoeGermuska opened 8 years ago

JoeGermuska commented 8 years ago

Task 1: remove that from the "authoring tool" (or possibly add clarification/link to FAQ?)

Task 2: investigate window message passing to see if there's a way to do this safely. I read about that some over the weekend, and I'm not really sure how we would. So maybe we can't do it.

scott2b commented 7 years ago

This is expected behavior when using iframes. I have added a note to the hash bookmarks option text to indicate it does not work with iframes. I would rather put efforts into componentizing timeline than to rig up message passing to the parent page. Given that we don't have control over the parent page, I would expect we would need a componentized embed anyway. It is possible all we would need to do is to have an embed component that handles the url manipulation, while itself sourcing in the content as an iframe. This is really broad speculation, however. Investigation will be required. De-escalating this to an enhancement.