search

NUKnightLab / TimelineJS3

TimelineJS v3: A Storytelling Timeline built in JavaScript. http://timeline.knightlab.com
Mozilla Public License 2.0
2.96k stars 620 forks source link

Document Cloud embeds sometimes overlap next/prev page and full-screen #330

Open JoeGermuska opened 8 years ago

JoeGermuska commented 8 years ago

A Zendesk user reported that sometimes the "next/previous" controls for a DC embed overlap with the "full screen" control.

image

I'm not sure if this is something we can control, but we should explore, or contact @knowtheory and co to see what they say

knowtheory commented 8 years ago

@JoeGermuska btw, in very small contexts would there be any interest in using our page embed type? http://documentcloud.github.io/documentcloud-pages/examples/

rosaliechan commented 7 years ago

I was looking into this today and it seems like it's not really something we can control @JoeGermuska. I could explore this more tomorrow though

rosaliechan commented 7 years ago

I set a minimum width so that the arrow does not overlap with the full screen. However, the issue when I did that was that the text on the right would sometimes go under the documentcloud embed. To resolve this, I changed skinny_size from 650 to 770. Thoughts on this? @scott2b You can view the pull request here: https://github.com/NUKnightLab/TimelineJS3/pull/519

rosaliechan commented 7 years ago

@knowtheory we might be interested. Is there a link to the source code for that style?