search

NUKnightLab / TimelineJS3

TimelineJS v3: A Storytelling Timeline built in JavaScript. http://timeline.knightlab.com
Mozilla Public License 2.0
3k stars 621 forks source link

I18N for accessibility changes #778

Closed JoeGermuska closed 2 years ago

JoeGermuska commented 2 years ago

A series of recent PRs (gathered under the Accessibility 2022 milestone) have greatly improved TimelineJS accessibility.

However, some of them introduce ARIA labels and other messages which should probably be factored out into the translation files.

The MVP for this task would be to locate them and move them to the base translations in Language.js. It doesn't seem feasible to have this issue block on getting actual translations for the 60+ languages supported, but those will fall back to the base until such time as we get translations contributed.

JoeGermuska commented 2 years ago

Fixed in d6f376ef0407f09cdf0d545202fec170469089a6