search

NUKnightLab / TimelineJS3

TimelineJS v3: A Storytelling Timeline built in JavaScript. http://timeline.knightlab.com
Mozilla Public License 2.0
2.99k stars 621 forks source link

Basic implementation of TikTok embeds #782

Open JoeGermuska opened 2 years ago

JoeGermuska commented 2 years ago

Addresses #781

The embeds basically work, although there is a painfully long lag in loading, and there doesn't seem to be any way to control the height of the embed, which means it overflows the available space on a typical timeline.

Will let this sit for a little to see if we (or anyone watching!) can figure those out, but I don't think they're blockers to integrating it.

JoeGermuska commented 2 years ago

After fooling around in the browser inspector, it seems like it's things in the embed which force the height to 740px. Since we can't control the internals, it seems that people will simply have to tolerate that the tiktok embed will, in most cases, overflow the "StorySlider" and the bottom will be covered by the navigation component.