NUKnightLab / TimelineJS3

TimelineJS v3: A Storytelling Timeline built in JavaScript. http://timeline.knightlab.com
Mozilla Public License 2.0
2.97k stars 620 forks source link

Medium embed code doesn't work #841

Open floredallennes opened 1 year ago

floredallennes commented 1 year ago

When i'm in step 4 it gives me a link that lead to one of Timeline example (women in computing) and not to my spreadshit. Althougt the preview is working.

JoeGermuska commented 1 year ago

I can't reproduce this. What browser and operating system are you using?

Are you saing that the embed code has a link that shows the timeline example? If so, can you paste the embed code you got here?

JoeGermuska commented 1 year ago

I'm sorry, somehow I completely overlooked "Medium" in the subject line of your report.

I'm still not sure I understand, though, because when I put a direct timeline link in a Medium article, it doesn't work at all -- where you describe it as embedding a different timeline (the default one which is shown if the timeline page is loaded without a source).

In fact, the problem with embeds in Medium is something we've known about for some time. We have been waiting quite a long time for a support request that is in with Embedly, the provider who makes those embeds work on Medium. I can try to ping them again, but at this point, it seems as though we aren't their priority.

floredallennes commented 1 year ago

Hi,

I figure the link to the medium article was missing. Here’s what happen when I try to publish it with médium, it shows me the exemple page.

@./chronologie-b202854a73fb @./chronologie-b202854a73fb>

Then, I tried to copy the link in the preview window, option you have from the main page (under the step 4) and It’s appear to work

https://cdn.knightlab.com/libs/timeline3/latest/embed/index.html?source=1eeRTTwHvXcXtAny_jsKufAMQSXV9wux-SuGUwc3Zp1U&font=Default&lang=en&initial_zoom=2&height=650 https://cdn.knightlab.com/libs/timeline3/latest/embed/index.html?source=1eeRTTwHvXcXtAny_jsKufAMQSXV9wux-SuGUwc3Zp1U&font=Default&lang=en&initial_zoom=2&height=650

I don’t know if the preview is only offered temporarily though.

Thanks

Flore

Le 12 sept. 2023 à 08:49, Flore DALLENNES @.***> a écrit :

Hi, Yes it has worked with just publishing a clickable link that leads to the woman in computing timeline

Here is the result

Le lun. 11 sept. 2023 à 19:03, Joe Germuska @. @.>> a écrit :

I'm sorry, somehow I completely overlooked "Medium" in the subject line of your report.

I'm still not sure I understand, though, because when I put a direct timeline link in a Medium article, it doesn't work at all -- where you describe it as embedding a different timeline (the default one which is shown if the timeline page is loaded without a source).

In fact, the problem with embeds in Medium is something we've known about for some time. We have been waiting quite a long time for a support request that is in with Embedly, the provider who makes those embeds work on Medium. I can try to ping them again, but at this point, it seems as though we aren't their priority.

— Reply to this email directly, view it on GitHub https://github.com/NUKnightLab/TimelineJS3/issues/841#issuecomment-1714266223, or unsubscribe https://github.com/notifications/unsubscribe-auth/BCP7V42FXWVJP5UKES3SLKDXZ475VANCNFSM6AAAAAA4TNCRKQ. You are receiving this because you are subscribed to this thread.

JoeGermuska commented 1 year ago

When I paste the timeline URL you sent into a draft Medium article, it does not have any effect. It just appears on a line of its own. This is the same behavior we've been getting with other timeline URLs for some time. On the other hand, when I do the same thing with a YouTube URL, it turns into an embed.

In short, it doesn't seem to work at all, not even "working" by showing an embed with the wrong content. If you're actually getting a Medium post that has any TimelineJS embed, we'd love to see that. If you tried to share the Medium URL, it looks as though GitHub obscured it as if it were an email address. If you have a working Medium URL post, please use the GitHub Issues text editor 'link' tool to make it linked text, and hopefully that will prevent GitHub from mangling it.

I have updated our support request with Embedly. It's been 3 months since they told us they'd look into it, and I've pinged them once about it since then with no response. Not sure if or when we'll hear from them.