search

NUKnightLab / blueline

An asset generator and style guide for Knight Lab websites
http://blueline.knightlab.com
Other
4 stars 0 forks source link

grunt deploy doesn't make files readable #1

Closed JoeGermuska closed 11 years ago

JoeGermuska commented 11 years ago

I ran grunt deploy and the example page template is 403. The grunt s3 task needs to make things world readable too...

srobbin commented 11 years ago

The current version of Blueline is a work in progress. The examples pages aren't being pushed in "deploy", which is why you're seeing the 403. I believe that, once they're part of the deploy process, they should be world readable by default.

JoeGermuska commented 11 years ago

ah; i didn't even look. thanks for clearing that up. WIP or not, it's handy to have it on the web. So maybe there should be a ticket to include them in deploy, but I'll take this as you saying "i know there are rough edges don't ticket me to death" :)

srobbin commented 11 years ago

Ha, no I didn't mean to say that. I think it's a good idea to have tickets as placeholders.

Maybe it's worthwhile to create a wip branch, and keep the master for release-ready code.

srobbin commented 11 years ago

Fixed in cd429237a