search

NUKnightLab / learncms

Learn.Knightlab.com CMS version
8 stars 5 forks source link

Scroll on popup windows (i.e. Text Editor, FTP Program) doesn't work, even if content goes beyond window dimensions #71

Open bdin opened 9 years ago

bdin commented 9 years ago

See: https://learn.knightlab.com/lesson/create-basic-website/ Click on FTP program; depending on how large your window is, the various FTP programs may not all appear in the popup window, and you don't have the ability to scroll down to view the rest of the programs

JoeGermuska commented 9 years ago

This is deployed to production. @emilywithrow @bdin or someone please verify and close this if satisfied

zachwise commented 9 years ago

Passing through the scroll change is the reason scroll blocking was implemented ref issue #7. I'll take a look at the issue. The solution that implemented scroll blocking was flawed but deemed better than the alternative until someone had the time to tackle this.

JoeGermuska commented 9 years ago

As far as I can tell this is fixed. I'm just waiting for someone to review it.

We may need to figure out a way to ring people's bells louder.

zachwise commented 9 years ago

It's definitely not fixed.

JoeGermuska commented 9 years ago

Here's a screencap of me scrolling the first capsule-unit on Create a Basic Website learn-scroll

Using the trackpad on a MacBook running Mac OS 10.10.5 and Chrome 46.0.2490.71

I see now that it doesn't work on Firefox or Safari :disappointed:

JoeGermuska commented 9 years ago

noted by @bdin in Slack:

in the inspect element section, it says #capsule-content.capsule-unit is still set to overflow: hidden, but when i change it to scroll it works