search

NUKnightLab / oembed-server

A system to take oembed requests for KnightLab's embeddable tools.
MIT License
3 stars 0 forks source link

Wordpress integration #1

Open JoeGermuska opened 8 years ago

JoeGermuska commented 8 years ago

this isn't really an issue with this server, but this seems like the easiest place to document things.

We can add ourselves to the Wordpress whitelist here:

https://github.com/WordPress/WordPress/blob/master/wp-includes/class-oembed.php

this will solve the discovery problems for TimelineJS and Juxtapose.

bomanimc commented 8 years ago

Hey Joe. I'm not sure how we go about getting Knight Lab added to the list. Do we just submit a pull request adding our URL to that file?

JoeGermuska commented 8 years ago

I thought maybe, but looks like not. From the homepage of the Wordpress git repo:

WordPress, Git-ified. Synced via SVN every 15 minutes, including branches and tags! This repository is just a mirror of the WordPress subversion repository. Please do not send pull requests. Submit patches to http://core.trac.wordpress.org/ instead. http://wordpress.org/

If you want to look into the right process for doing that, you're welcome to! Assign this issue to yourself if you do (if you can?)

bomanimc commented 8 years ago

Oh! I guess I assumed that you were assigning it to me. Actually, I'd probably prefer if you or someone else did this one haha.

JoeGermuska commented 8 years ago

I submitted a Trac ticket https://core.trac.wordpress.org/ticket/36301

we'll see if they take it.

JoeGermuska commented 8 years ago

We are supposed to answer all the questions at https://make.wordpress.org/core/handbook/contribute/design-decisions/#whitelisting-oembed-providers

Odds are not great that we'll persuade them. It may be that we should simply write a wordpress plugin which registers our own oembed providers. It would be a super simple plugin to write, given what we've learned from the more elaborate Timeline/WP plugin.