search

NULLx76 / ringbuffer

A fixed-size circular buffer written in Rust.
https://crates.io/crates/ringbuffer
MIT License
95 stars 20 forks source link

add const new fn #58

Closed jdonszelmann closed 1 year ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #58 (24535ab) into master (755e073) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #58   +/-   ##
=======================================
  Coverage   83.26%   83.26%           
=======================================
  Files           5        5           
  Lines         245      245           
=======================================
  Hits          204      204           
  Misses         41       41
Impacted Files Coverage Δ
src/with_const_generics.rs 91.22% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

NULLx76 commented 2 years ago

I don't think this needs a feature gate. Ideally I'd also have this as the default version of new but I'm not sure how bad the error messages are. We should add some tests in any case

jdonszelmann commented 2 years ago

there is no error message. It's just a plain panic.

jdonszelmann commented 1 year ago

Shall we merge this?