search

NUMde / compass-numapp-web

NUM COMPASS web app
MIT License
0 stars 0 forks source link

⬆️🔒️ upgrade remaining dependencies #36

Closed jonathan-reisdorf closed 2 years ago

jonathan-reisdorf commented 2 years ago

Attempt to upgrade dependencies listed in https://github.com/NUMde/compass-numapp-web/issues/15

❗ untested, no local backend set up to test anymore. Build works and UI seems to work as expected. cc @mbastian93

Note: To upgrade @d4l/web-components-library to v3, package @stencil/router would have to be replaced with https://github.com/ionic-team/stencil-router-v2. However, development on the v2 router was recently dropped for lack of maintainers. The v2 router itself works just fine, has a very small and clean code base and provides plenty of improvements over the v1 router (it will also remove a lot of warnings in the DevTools console currently coming from the v1 version), that's why D4L's web components library decided to upgrade to it despite it never having officially reached a final version.

mbastian93 commented 2 years ago

It seems like the used version of stencil is not compatible with the used version of jest; running npm test results in

[56:58.4]  @stencil/core
[56:58.7]  v2.17.0 🚂

[ ERROR ]  Please install supported versions of dev dependencies with either npm or yarn.
           npm install --save-dev @types/jest@27.0.3 jest@27.0.3 jest-cli@27.4.5
jonathan-reisdorf commented 2 years ago

Thank you, I have now downgraded the jest dependencies accordingly