search

NUS-Project-SaBai / FrontEnd

1 stars 1 forks source link

Standardized DevOps #109

Closed taggyhan closed 4 months ago

taggyhan commented 4 months ago

Standarised the pretiierrc file as well as eslint.config.js file

eslint config is based on

  1. https://eslint.org/docs/latest/use/configure/ 2.https://eslint.org/docs/latest/use/configure/configuration-files 3.https://eslint.org/docs/latest/rules/

prettierrc.json is mainly based on

  1. https://gist.github.com/adbutterfield/6b91625b5b07ca2c29f6322245e3e2bb?permalink_comment_id=3968450
  2. https://prettier.io/docs/en/options.html

bypassed pre-commit hooks to push as some of the files had issues that did not match pre-comitt hooks requirement

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
front-end ❌ Failed (Inspect) Jul 15, 2024 10:50am
taggyhan commented 4 months ago

@davidgohzk i think the pre-comitt hook did change some of the files, I'm not sure if the practice sabai wants to follow so do take a look and let me know if its fine!

davidgohzk commented 4 months ago

Alright, looks good, we will standardise the code at a later time as it is not a top priority at the moment.