Inconsistency in graph structure

NUS-SNL / p4-traffictool

p4-traffictool helps in packet generation, parsing and dissection for popular backends

MIT License

40 stars 10 forks source link

Inconsistency in graph structure #33

Open rhl-bthr opened 4 years ago

rhl-bthr commented 4 years ago

Index 1 of an edge in the graph is of type List. See common.py#L111, but is replaced with a string in some cases in GenTrafficScapy.py#L357

Incidentally, this does not generate a bug, since the cases in which it is replaced with a string - it is interpreted as a string later on, and as a List otherwise.

Not a good practice. Is this worth fixing @rajkiranjoshi ?

rajkiranjoshi commented 4 years ago

Definitely worth fixing 👍