search

NUWCDIVNPT / stig-manager

An API and client for managing STIG assessments
Other
120 stars 28 forks source link

FEATURE REQUEST: Asset Created, Added STIGs Allowed CKL Import Options #1235

Closed jeremygifford closed 4 months ago

jeremygifford commented 8 months ago

Is your feature request related to a problem? Please describe. It's tempting for users to bulk upload a folder of CKL files without prescreening them for things like old assets, STIGs, or incorrect asset names. More automated screening options integrated within the import process would greatly help in maintaining the target accuracy of collections.

Describe the solution you'd like Similar to how the Importing results table shows 'Created', 'Added STIGs', 'Inserted', 'Updated', 'Rejected' metrics. We would like two new Import Options to be added for whether creating new assets or adding new STIGs for assets is allowed for the import. For example: if 'Allow Asset Creation' Import Option is false, then any operations that rely on that would be rejected.

Describe alternatives you've considered Current plan to work around the problem is to rely on Full collection grant to limit new asset/STIG association creations when bulk importing CKLs. There are a few limitations with this approach, users with Manage or higher grants won't be able to bulk upload with those protections, and current lack of bulk upload GUI option for Full users (ticket #1045 https://github.com/NUWCDIVNPT/stig-manager/pull/1228)

cd-rite commented 8 months ago

Hi @jeremygifford Our approach to this with PR #1128 should get you the desired behavior. This PR adds an import button to the Collection Dashboard for all users. When invoked from the Dashboard, the import wizard will NOT create new Assets or STIG assignments, even if the user is a manager/owner of the Collection. When invoked from the Manage Collection interface (available only to managers/owners), the import wizard will continue to create new Assets and STIG Assignments as before. A tooltip for each button will describe these different behaviors. So when just updating Reviews, users should invoke the wizard from the Dashboard. When performing the "manager-ish" function of creating new Assets, etc, users should invoke the wizard from the Manage Collection interface. This approach is not quite as explicit as the options you are looking for, but I think gets us most of the way there in a much quicker timeframe.

jeremygifford commented 8 months ago

Sounds good.

cd-rite commented 4 months ago

Closing this, as the new import from dashboard feature satisfies perhaps 90% of the need here. Feel free to reopen or create a new issue if this is not satisfactory. Thank you for the suggestion!