Update vision collection to remove artefacts in collected images

LachlanCourt commented 3 years ago

Goal of this PR is to solve issue artefacts cropping up in a number of the images. It works and is ready for testing now I just want to change the config slightly still before we merge. (Gotta go into the lab this arvo to do that but wanted to get this up asap)

TODO

[x] Remake rotations (I think that they are slightly out of date, it still works though)
[x] Merge master after Webots migration
[x] General code tidy up
[ ] ~Read robots in from file~
[x] Update README

ysims commented 3 years ago

Oh also change the PR title so it's not just the branch name.

ysims commented 2 years ago

This is ready for a review. I've gone through it and refactored it a bit. Notable changes

Rotations are now a random angle rather than a fixed number of preset rotations
Heights are read from the proto file
Main has been merged, tbh it also has the libcppcontroller stuff in it as well which is from #88 otherwise it won't run. #88 should be merged first.
Cleaned up the code, made sure clang tidy is happy
README didn't look like it needed updating but I expanded it a little
I can't remember what we decided on for the goals but I'm pretty sure we want to detect the small goal posts separately and remove the net (segmentation doesn't work properly if the net is blocking it). So I've put this back in.
Renamed the controller to something that better describes what it does
Changed the other robots to use the void controller since it removes the constant warnings

There is one annoying thing that doesn't really matter if you ignore it and press play:

An error message from RobotisOp3.proto. The other robots probably have the same error. It doesn't stop the program from working.

ysims commented 2 years ago

@LachlanCourt informal request for review since it's your PR so I can't request it properly :stuck_out_tongue_closed_eyes:

LachlanCourt commented 2 years ago

I'll have a look tomorrow 😊

LachlanCourt commented 2 years ago

This works for me :+1: I can't approve it tho bc it's my own PR initially :laughing:

ysims commented 1 year ago

Can someone review who isn't myself or @LachlanCourt pls ty

NUbots / NUWebots

Update vision collection to remove artefacts in collected images #64