NUbots / NUbook

The NUbots team handbook and documentation.
https://nubook.nubots.net
MIT License
7 stars 5 forks source link

Update algolia docsearch component to V3 #297

Closed LachlanCourt closed 8 months ago

LachlanCourt commented 1 year ago

Several dramas with the existing docsearch component lead to me starting investigation around updating it a LONG time ago, I finally got around to finishing it today 🎉 It looks a little bit different but I've tried to match the styles as closely as possible, this is totally open to feedback, I was trying to juggle minimal customisations vs looking nice so let me know if you think something looks off and if you have any suggestions :)

Preview

Note that the links that will show up in the search will link to the active site, not back to the preview so if you are clicking around just make sure you keep an eye on the URL. Pls also consider checking on different screen sizes, mobile, tablet etc

https://deploy-preview-297--nubook.netlify.com/

Algolia

netlify[bot] commented 1 year ago

Deploy Preview for nubook ready!

Name Link
Latest commit b38064770020d070ca5266f318296b9202a79344
Latest deploy log https://app.netlify.com/sites/nubook/deploys/65d0066a6fa51c0008e2dd79
Deploy Preview https://deploy-preview-297--nubook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ysims commented 1 year ago

Looks good on mobile. On desktop I noticed the colour of the background when the search is clicked is blue-ish. I feel like a grey would be better, particularly when in dark mode.

LachlanCourt commented 1 year ago

What part of the search are you clicking sorry @ysims ? I don't seem to be able to reproduce 🤔

ysims commented 1 year ago

@LachlanCourt

image

Outside of the search box, the rest of the site gets a blue-grey overlay.

LachlanCourt commented 1 year ago

Have updated to a light grey now instead, lemme know what you think @ysims

ysims commented 1 year ago

Looks good!