search

NV / CSSOM

Unmaintained! ⚠️ CSS Object Model implemented in pure JavaScript. Also, a CSS parser.
https://nv.github.io/CSSOM/docs/parse.html
MIT License
751 stars 99 forks source link

Add support for CSSSupportsRule #94

Closed thomashigginbotham closed 6 years ago

thomashigginbotham commented 6 years ago

Error is no longer thrown when CSS contains @supports, and @media/@supports rules can be nested.

Hypnosphi commented 6 years ago

@NV is there anything that blocks merging and releasing this? Can I help in any way?

NV commented 6 years ago

The pull request looks good at the first glance, but it needs tests.

I apologize for not responding for so long.

devrelm commented 6 years ago

@thomashigginbotham Do you have time to add tests? If not, I can try to pick up your branch and take a whack at it.

thomashigginbotham commented 6 years ago

@devrelm Sure, please do. I likely won't have time in the near future.

devrelm commented 6 years ago

@NV I added some tests and put up another PR over at #96

NV commented 6 years ago

Fixed in #96

huchenme commented 6 years ago

@NV can we do a new release to get in this fix?

grahamlicence commented 6 years ago

@huchenme it's available in 0.3.4