NV / CSSOM

Unmaintained! ⚠️ CSS Object Model implemented in pure JavaScript. Also, a CSS parser.
https://nv.github.io/CSSOM/docs/parse.html
MIT License
752 stars 99 forks source link

CSSFontFaceRule is missing from npm package exports #97

Closed amitzur closed 6 years ago

amitzur commented 6 years ago

versions 0.3.2 and 0.3.3 are missing CSSFontFaceRule from exports. I couldn't find it in the source code, as tags for these versions don't exists.

For reference, here's the contents of index.js for v0.3.3:

exports.CSSStyleDeclaration = require("./CSSStyleDeclaration").CSSStyleDeclaration;
exports.CSSRule = require("./CSSRule").CSSRule;
exports.CSSStyleRule = require("./CSSStyleRule").CSSStyleRule;
exports.CSSImportRule = require("./CSSImportRule").CSSImportRule;
exports.MediaList = require("./MediaList").MediaList;
exports.CSSMediaRule = require("./CSSMediaRule").CSSMediaRule;
exports.StyleSheet = require("./StyleSheet").StyleSheet;
exports.CSSStyleSheet = require("./CSSStyleSheet").CSSStyleSheet;
exports.parse = require("./parse").parse;
exports.clone = require("./clone").clone;
amitzur commented 6 years ago

I'd happily create a PR, but it's not an issue in the code in master, and I'm not sure where the change that created this issue was introduced

NV commented 6 years ago

Please check v0.3.4 that I just released.

I apologize I no longer actively maintain CSSOM. I didn't remember how index.js was generated, so I just added it to the repo and manually put CSSFontFaceRule in there. The build system is terribly outdated and should be improved.

amitzur commented 6 years ago

I did something similar in a fork. The difference is I ran the actual build so I also got more objects inside like CSSSupportsRule which I needed.

Thanks for your effort although you're not actively maintaining this!

NV commented 6 years ago

Fixed in #98.