search

NV / faviconize-google.js

Adds favicons to each link offered by Google search results.
http://userscripts.org/scripts/show/58177
Other
24 stars 12 forks source link

May I take over this? #12

Open Sir-Cumference opened 7 years ago

Sir-Cumference commented 7 years ago

Can I have your permission to write a functioning script for this?

NV commented 7 years ago

Do you want to be a maintainer?

Please send a pull request first. If everything looks good I can add you as a collaborator so you can have a push access to the repository.

Sir-Cumference commented 7 years ago

@NV Actually, I don't have much experience using Github, so I wouldn't really know how to do that...

However, a few months ago I wrote a script for myself and ran it with Tampermonkey. I have a gist for it here.

Sir-Cumference commented 7 years ago

@NV So, uh, did you see it?

joeytwiddle commented 6 years ago

+1 for Mutation Observer -1 for jQuery ;-)

What problem does your script solve @Sir-Cumference ?

NV and I have also attacked the problem of loading favicons when new results are loaded into the page, albeit in different ways. (Mine was naughty, using setTimeout()! So -5 for me.)

Sir-Cumference commented 6 years ago

@joeytwiddle Yeah, this happens to be a case where jQuery made my life a whole lot easier, thanks to .each().

For starters, the script works, whereas this extension doesn't anymore. Not to mention, it should be supported by all browsers, including Firefox. My code should also get more accurate/higher definition favicons; I append /favicon.ico to the domain (typically where favicons are found), but if there's nothing there, I use google's favicon index as a backup (lower quality, but more often available).

On a side note, I updated my script to be more efficient/less hacky.