search

NVB9ALT / Realism-pack.

An addon that adds new features and realism fixes to GeoFS.
13 stars 7 forks source link

realismGo is not defined on line 22 of the tampermonkey version. #14

Closed Ampersand20 closed 1 year ago

Ampersand20 commented 1 year ago

image image

NVB9ALT commented 1 year ago

That's strange; I double-checked both the tampermonkey code and the core code that are in this GitHub repo and it should be able to execute the function in realismScript once realismScript has loaded. It's probably throwing this error because realismGo hasn't been mentioned anywhere in the tampermonkey code - try running the addon anyway; once realismScript has loaded, realismGo should be an executable function.

Ampersand20 commented 1 year ago

do i have to add realismScript to this as well?

On Fri, Feb 3, 2023 at 10:17 PM NVB9ALT @.***> wrote:

That's strange; I double-checked both the tampermonkey code and the core code that are in this GitHub repo and it should be able to execute the function in realismScript once realismScript has loaded. It's probably throwing this error because realismGo hasn't been mentioned anywhere in the tampermonkey code - try running the addon anyway; once realismScript has loaded, realismGo should be an executable function.

— Reply to this email directly, view it on GitHub https://github.com/NVB9ALT/Realism-pack./issues/14#issuecomment-1416645794, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXDW7TSAU22VK6PPEFV4UHDWVXC5DANCNFSM6AAAAAAUQ4SF4U . You are receiving this because you authored the thread.Message ID: @.***>

NVB9ALT commented 1 year ago

You shouldn't have to; the tampermonkey script will load realismScript from the url, and when it loads, execute the function that realismScript contains.

Ampersand20 commented 1 year ago

It still isn't working. Tampermonkey says that there are no active userscripts.

On Sat, Feb 4, 2023 at 12:03 PM NVB9ALT @.***> wrote:

You shouldn't have to; the tampermonkey script will load realismScript from the url, and when it loads, execute the function that realismScript contains.

— Reply to this email directly, view it on GitHub https://github.com/NVB9ALT/Realism-pack./issues/14#issuecomment-1416801017, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXDW7TUTTAMRL6XIVPQ5LPDWV2DVBANCNFSM6AAAAAAUQ4SF4U . You are receiving this because you authored the thread.Message ID: @.***>

NVB9ALT commented 1 year ago

That's even stranger - the only reason I can think of for that would be if you're running GeoFS on a proxy or something, where the domain of the website isn't "https://geo-fs.com". Try the bookmarklet version.

Ampersand20 commented 1 year ago

okay.

On Sat, Feb 4, 2023 at 2:05 PM NVB9ALT @.***> wrote:

That's even stranger - the only reason I can think of for that would be if you're running GeoFS on a proxy or something, where the domain of the website isn't "https://geo-fs.com". Try the bookmarklet version.

— Reply to this email directly, view it on GitHub https://github.com/NVB9ALT/Realism-pack./issues/14#issuecomment-1416827406, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXDW7TUAHTV2SLUBKQ4JCK3WV2R75ANCNFSM6AAAAAAUQ4SF4U . You are receiving this because you authored the thread.Message ID: @.***>

Ampersand20 commented 1 year ago

well the bookmarklet addon mostly works but the chat thing in options is not responding.

On Sat, Feb 4, 2023 at 2:27 PM Tyler Jeane @.***> wrote:

okay.

On Sat, Feb 4, 2023 at 2:05 PM NVB9ALT @.***> wrote:

That's even stranger - the only reason I can think of for that would be if you're running GeoFS on a proxy or something, where the domain of the website isn't "https://geo-fs.com". Try the bookmarklet version.

— Reply to this email directly, view it on GitHub https://github.com/NVB9ALT/Realism-pack./issues/14#issuecomment-1416827406, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXDW7TUAHTV2SLUBKQ4JCK3WV2R75ANCNFSM6AAAAAAUQ4SF4U . You are receiving this because you authored the thread.Message ID: @.***>

NVB9ALT commented 1 year ago

yea it's been saying "typerror failed to fetch" for me, the chat site might be down. I'll fix it at some point.

Since the bookmarklet version appears to work, the issue is likely with the Tampermonkey version's triggers. If you're 100% sure you installed it correctly, I'll ask the wiki if anyone else a) uses the tampermonkey version, and b) is having issues with it. It's also possible that you run GeoFS in a strange way that upsets Tampermonkey.

Ampersand20 commented 1 year ago

I'm on Mac is all.

On Sat, Feb 4, 2023 at 3:24 PM NVB9ALT @.***> wrote:

yea it's been saying "typerror failed to fetch" for me, the chat site might be down. I'll fix it at some point.

Since the bookmarklet version appears to work, the issue is likely with the Tampermonkey version's triggers. If you're 100% sure you installed it correctly, I'll ask the wiki if anyone else a) uses the tampermonkey version, and b) is having issues with it. It's also possible that you run GeoFS in a strange way that upsets Tampermonkey.

— Reply to this email directly, view it on GitHub https://github.com/NVB9ALT/Realism-pack./issues/14#issuecomment-1416842631, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXDW7TX7R7TUCH2KSO5MQE3WV23H5ANCNFSM6AAAAAAUQ4SF4U . You are receiving this because you authored the thread.Message ID: @.***>

Ariakim-Taiyo commented 1 year ago

That error is thrown because realismGo() is not defined in this context. realismGo() isn't actually defined anywhere in the program, rather it is in a script element that is added after the script has been executed. Usually TM doesn't fail to compile from that sort of error, but it may help to define realismGo() as an empty function which will then be overwritten by the script tag so that TM can compile it. That's just speculation on my part, it is possible that something else is wrong, and it most likely is a difference between OSes. It could also be browser-based, since Chrome uses different extension architecture than Safari. It's always best to just define external things with non-constant definitions, such as var. Don't use const or let since those are static.

kolos26 commented 1 year ago

I have solved the same problem in LiverySelector by adding this line to the end: window.realismGo = realismGo and I'm also calling the window.realismGo() in the script.

NVB9ALT commented 1 year ago

I was thinking the same thing, I guess I just wasn't expecting Tampermonkey to be so rigorous with this sort of thing. I'll fix it.

DevHunter77 commented 1 year ago

I really don't like certain minorities

NVB9ALT commented 1 year ago

@Ampersand20 try the new version of the Tampermonkey in 10 minutes or so from the time of this message (to give raw.githack.com enough time to update)

Ampersand20 commented 1 year ago

I'm using Brave as a browser, which is based on Chrome, but it still shouldn't be having any problems. I'll retry.