NVB9ALT / Realism-pack.

An addon that adds new features and realism fixes to GeoFS.
13 stars 7 forks source link

Aircraft loading in before terrain #32

Closed AbnormalHuman closed 8 months ago

AbnormalHuman commented 8 months ago

The planes loaded in before the terrain, specifically after this recent update two days ago. This causes the thing to glitch the plane and terrain into pitch black. Can we fix the code a little bit?

AbnormalHuman commented 8 months ago

Also I discovered that after re-adding the runway layovers, the game forces the terrain to load before the plane, therefore solving the issue. But yours will prob be still removed, so I guess we gotta find another way...

NVB9ALT commented 8 months ago

Can you send me a screenshot? Because based on your description it may be a known issue with the over-G blackout shader.

AbnormalHuman commented 8 months ago

Ye I think is that. I will send a screenshot later to you if that's OK?

AbnormalHuman commented 8 months ago

And again, this issue happened since the shader by the other coder was added, like some days ago. Screen recording 2024-01-09 08.02.56.webm

NVB9ALT commented 8 months ago

Ye that's what I thought was happening. The cause of that glitch is the shader for the over-G blackout loading before the advanced atmosphere shader does. There is a statement in the code that delays loading the over-G blackout until the advanced atmosphere is loaded, in order to prevent this glitch, but I guess it didn't work this time? Are you using the Tampermonkey version?

NVB9ALT commented 8 months ago

The recent addition of Ariakim's shaders might have something to do with it, but I'm not sure how it's causing the glitch, unless it's causing the advanced atmosphere to load twice...

AbnormalHuman commented 8 months ago

Yes, I am using the Tampermonkey script. Is there a way to have a 15-second delay before the addon is activated?

NVB9ALT commented 8 months ago

That explains it. When you run the bookmarklet version after the advanced atmosphere loads, everything works fine AFAIK. I will see what I can do when I get home from school so I can use my personal computer.

Good news is that I now know the Tampermonkey plugin is at least trying to run the script.

AbnormalHuman commented 8 months ago

Ye, the Tampermonkey script should have a 15-second delay before it starts working.

NVB9ALT commented 8 months ago

I did some testing when I got home from school yesterday, and found that running the bookmarklet before advanced atmosphere loads causes the glitch as well. This is odd, because there is an "if" statement in the code specifically to stop this from happening. Problem is, a timer delay isn't a good fix. The time it takes for GeoFS to load fully can vary from computer to computer, browser to browser, and maybe even on how many tabs you have open. Maybe I'll try and set up a script loading order system, so that the over-G blackout loads after Ariakim's shaders (as that's my best guess as to what the problem is).

NVB9ALT commented 8 months ago

The over-G blackout shader now (in theory) only loads if the SSR shaders are loaded. See if:

AbnormalHuman commented 8 months ago

Nope, still not working.

NVB9ALT commented 8 months ago

Darn. Not sure what to do now. The easiest thing to do would be to delete the Tampermonkey version, but I want to keep that option available.

NVB9ALT commented 8 months ago

It now attempts to load the over-G blackout every 20 seconds, hopefully giving enough time for things to sort out. See if it works.

EDIT: I tested it and it did not work...

AbnormalHuman commented 8 months ago

Ye I know coding sometimes can be hard...

Gamer1029384756 commented 8 months ago

I have the same problem as well.

Gamer1029384756 commented 8 months ago

I’m using the tampermonkey version too.

NVB9ALT commented 8 months ago

It now only loads the SSR shaders once the over-G blackout shader is loaded, see if it works.

AbnormalHuman commented 8 months ago

It is finally working! Thanks a lot. After years, I think the issue can be finally closed now XD

NVB9ALT commented 8 months ago

Making the software not be a buggy broken mess is like the bare minimum from a developer, but thanks for the thanks anyways.

Gamer1029384756 commented 8 months ago

I’ll check in a few days. Thanks anyway!