feature(nve-link-card): Created new component

NVE / Designsystem

MIT License

1 stars 0 forks source link

feature(nve-link-card): Created new component #241

Closed NVEJoel closed 1 month ago

NVEJoel commented 1 month ago

PR:

Created new card-link component from the design https://www.figma.com/design/0eXhyUrUF7fWi1VaphfpEu/04---%E2%9D%96-Komponenter?m=dev
Fixed correct css to make icons bigger at components/nve-icon.html
Make props optionals at CodeExamplePreview to remove all console.logs warnings.
Removed import of defineProps since it is unnecessary

github-actions[bot] commented 1 month ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-0c645bd03-241.westeurope.5.azurestaticapps.net

tomapedersen commented 1 month ago

Måten denne ser ut til å være implementert på er et wcag-brudd. Linker bør alltid være <a href="">-elementer. Teoretisk kan man også bruke role=link , men det anbefales ikke, siden det da ikke implementerer funksjon som ctrl+click eller høyreklikk på en link

github-actions[bot] commented 1 month ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-0c645bd03-241.westeurope.5.azurestaticapps.net

github-actions[bot] commented 1 month ago

Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-meadow-0c645bd03-241.westeurope.5.azurestaticapps.net