NVIDIA-AI-IOT / jetbot

An educational AI robot based on NVIDIA Jetson Nano.
MIT License
3k stars 1.03k forks source link

Wiki: Software-Setup.md - update "Replace the old notebook" instructions #48

Closed idcrook closed 5 years ago

idcrook commented 5 years ago

I made a fix to Software-Setup wiki page for "rsync: not found" here commit 1, commit 2 in a clone of the wiki repo. As I cannot find a better way to update wiki I created this issue as an invitation to merge my changes.

Here's the salient snippet:

 3. Replace the old notebooks with the new notebooks by entering
     ```bash
-    rsync jetbot/notebooks ~/Notebooks
+    rsync -avr notebooks ~/Notebooks
jaybdub commented 5 years ago

Hi idcrook,

I've added sudo apt-get install rsync to the wiki.

Thanks! John

dvillevald commented 5 years ago

When I run jetbot@jetbot:~/jetbot$ rsync -avr notebooks ~/Notebooks it does not replace the old (individual) folders with examples. Instead it creates a new subfolder named notebooks in folder Notebooks.

Should not it include the trailing slash after notebooks?: jetbot@jetbot:~/jetbot$ rsync -avr notebooks/ ~/Notebooks

idcrook commented 5 years ago

Thanks @jaybdub As it is,it still doesn't work. rsync cmd as written only does top-level dir, not recursively (subdirs).

$ rsync notebooks ~/Notebooks
skipping directory notebooks

Also, it does not follow existing flow there, as it is written for wrong working directory. It should instead be, as @dvillevald corrected above:

rsync -avr notebooks/. ~/Notebooks

I've updated my wiki clone's Software-Setup.md to the following:

3. Replace the old notebooks with the new notebooks by entering
    ```bash
    rsync -avr notebooks/. ~/Notebooks

If you get the following error, install rsync and try again.

     jetbot@jetbot:~/jetbot$ rsync -avr notebooks/. ~/Notebooks
     bash: rsync: command not found
     jetbot@jetbot:~/jetbot$ sudo apt install -y rsync
idcrook commented 5 years ago

as mentioned in https://github.com/NVIDIA-AI-IOT/jetbot/issues/46#issuecomment-487268998, the rsync command won't work as is. It will now just see that directory is there and "skip".

It should be something that includes -a or -r switch to recursively rsync subdirectories:

rsync -av notebooks/. ~/Notebooks
idcrook commented 5 years ago

The rsync command is still broken on the Wiki.

However, I am going to close this issue:

  1. On GitHub the ease of updating a "wiki" is completely not in the spirit of wiki; GitHub should either fix this aspect or call it something else
  2. A search of issues for rsync will turn up this issue.