search

NVIDIA-Genomics-Research / AtacWorks

Deep learning based processing of Atac-seq data
https://clara-parabricks.github.io/AtacWorks/
Other
128 stars 23 forks source link

updated output folder name in tutorial 1 #154

Closed avantikalal closed 4 years ago

ntadimeti commented 4 years ago

can you also do the following

  1. change all train_files to files_train. I merged a PR that only updates one command, I didn't realize there were many train commands.
  2. Tutorial1 & 2 : Add step to download all data files into a new folder data or something. This will prevent users from using default configs and running into issues.
ntadimeti commented 4 years ago

Testing the tutorial1 and 2 instructions. Will update here

ntadimeti commented 4 years ago

There seems to be a bug in the parser itself, it's not picking up any custom configs. I will create a PR to look into that and add appropriate tests.