search

NVIDIA-Genomics-Research / AtacWorks

Deep learning based processing of Atac-seq data
https://clara-parabricks.github.io/AtacWorks/
Other
128 stars 23 forks source link

replace gpu: None with a more intuitive config option #168

Closed ntadimeti closed 4 years ago

ntadimeti commented 4 years ago

Purpose of gpu: None argument in config file is confusing. Users are confused whether it needs to be set to ALL gpuIDs for multi-GPU configuration. What None means and does in the context of multi-GPU setting.

Proposed ideas: -> rename gpu to gpuID to make the purpose of the variable clearer. -> Support specification of multiple gpuIDs (if only one index, run in single GPU mode, if more than one, it will be distributed but only using the gpu whose indices are provided through config) and a string "all" which then means a multi-GPU setting that uses ALL available GPUs. -> Additionally, add detailed comments in the default config file to make the usage clear. Users may not want to run python main.py --help to understand the usage of each config option.

ntadimeti commented 4 years ago

Being addressed in this PR: https://github.com/clara-parabricks/AtacWorks/pull/177

ntadimeti commented 4 years ago

done.