search

NVIDIA-Genomics-Research / GenomeWorks

SDK for GPU accelerated genome assembly and analysis
https://clara-parabricks.github.io/GenomeWorks/
Apache License 2.0
286 stars 76 forks source link

[pygw] better fix for intermittent test failure #477

Closed tijyojwad closed 4 years ago

tijyojwad commented 4 years ago

The problem is that in some cases the CudaStream object is destroyed before the CudaAlignerBatch object. Keeping a reference to the stream object should resolve this issue since python does reference counting, but through tracking reference counts it appears that the reference is getting lost somewhere. The issue is resolve by explicitly increasing and decreasing the ref count for stream within the cudaaligner and cudapoa batch objects.

It's a more permanent fix, but still not sure why the python ref counting mechanism appears to be broken. Tracking this in https://github.com/clara-parabricks/GenomeWorks/issues/476

raydouglass commented 4 years ago

rerun tests

tijyojwad commented 4 years ago

rerun tests