NVIDIA-Genomics-Research / GenomeWorks

SDK for GPU accelerated genome assembly and analysis
https://clara-parabricks.github.io/GenomeWorks/
Apache License 2.0
286 stars 76 forks source link

[cudamapper] Overlaps at the same position in an index are dropped even when query and target files are not the same. #503

Closed edawson closed 4 years ago

edawson commented 4 years ago

When using two different FASTA files, reads at index i in the query index and index j in the target index are not overlapped when i == j. This is because of a check that was introduced in https://github.com/clara-parabricks/GenomeWorks/blob/0702c2ffd672fa04887f3b4e82bfd18d1d213218/cudamapper/src/overlapper.cpp#L25, and is valid for all-to-all but not sequence-to-reference overlapping.

The filtering condition should be ignored when not running in all-to-all mode.