search

NVIDIA-Genomics-Research / GenomeWorks

SDK for GPU accelerated genome assembly and analysis
https://clara-parabricks.github.io/GenomeWorks/
Apache License 2.0
286 stars 76 forks source link

[common] Rename device_copy_n to reflect non-blocking behavior #541

Closed ahehn-nv closed 3 years ago

ahehn-nv commented 4 years ago

The version of device_copy_n which takes a CUDA stream argument https://github.com/clara-parabricks/GenomeWorks/blob/74e6424c156a7ee15b4137d4788a4257ee6482c4/common/base/include/claraparabricks/genomeworks/utils/cudautils.hpp#L138 should be renamed to device_copy_n_async to make the non-blocking behavior more obvious.

The blocking three-argument version of device_copy_n should remain as is.

ahehn-nv commented 4 years ago

Furthermore, device_copy_n and device_copy_n_async should be moved one namespace up - from claraparabricks::genomeworks::cudautils to claraparabricks::genomeworks.