search

NVIDIA-Genomics-Research / GenomeWorks

SDK for GPU accelerated genome assembly and analysis
https://clara-parabricks.github.io/GenomeWorks/
Apache License 2.0
285 stars 76 forks source link

[common] Fixed a compiler warnings and a problem with CUDA 11 #561

Closed ahehn-nv closed 4 years ago

ahehn-nv commented 4 years ago

Hotfix for #554 and experimental CUDA 11 support.

ahehn-nv commented 4 years ago

@tijyojwad In order to not have too many hotfix releases, we might want to combine this with a fix for CUDA 11. I don't have time to work on that right now, but I'm happy to merge a PR against my branch.

tijyojwad commented 4 years ago

agreed, @ahehn-nv - @atadkase can you create a quick PR with the fix to enable CUDA 11 into this branch? We decided to make the gw_cuda_gen_all_arch OFF by default in CMakeLists.txt. This would need an update to the CMakeLists.txt and a change to ci/common/build-test-sdk.sh with line 30 updated to include gw_cuda_gen_all_arch=ON. Was there anything else that's needed to enable CUDA 11?

ahehn-nv commented 4 years ago

@tijyojwad Are we sure these changes won't break the python packages - if we only compile for one architecture by default?

tijyojwad commented 4 years ago

@tijyojwad Are we sure these changes won't break the python packages - if we only compile for one architecture by default?

Glad you mentioned this again. I was under the impression the build-test-sdk.sh update took care of cmake flags for python builds as well, but then I double checked and it was actually in a different place. So I just pushed a fix for that. Thanks for bringing it up!