search

NVIDIA-Genomics-Research / GenomeWorks

SDK for GPU accelerated genome assembly and analysis
https://clara-parabricks.github.io/GenomeWorks/
Apache License 2.0
284 stars 76 forks source link

[logging] fix spdlog incompatibility with gcc9 #592

Closed tijyojwad closed 4 years ago

tijyojwad commented 4 years ago
  1. WAR fix for spdlog with gcc9. disable logging for gcc9
  2. enable SAM support by default and fix cmake compile option for SAM
nvvishanthi commented 4 years ago

@tijyojwad since the definition of GW_BUILD_HTSLIB is done per-target in this PR, and right now it's only done for libcudamapper, I believe you would have to add it to the main cudamapper-bin target as well as sample_cudamapper target.

It should be easy, adding the following to cudamapper/CMakeLists.txt: target_compile_definitions(${MODULE_NAME}-bin PUBLIC GW_BUILD_HTSLIB)

and adding the following to cudamapper/samples/CMakeLists.txt: target_compile_definitions(${MODULE_NAME} PUBLIC GW_BUILD_HTSLIB)

nvvishanthi commented 4 years ago

Actually, the above may not be true, since PUBLIC implies that the compile definitions are exposed when linking against libcudamapper. Correct if my understanding is wrong anywhere. LGTM

tijyojwad commented 4 years ago

Thanks @nvvishanthi ! Made those changes to the PR now.