Closed gsneha26 closed 3 years ago
add to allowlist
I noticed the code style check failed.
@gsneha26 : when you build with cmake, execute make format
in the build directory to fix the code formatting automatically. It should pass the test then. (You might need to install "clang-format" for make format
to work - most Linux distributions provide a package for it.)
Hi @gsneha26 - friendly ping for the comments on this PR. Let us know if you have any clarifying questions or need help!
@ahehn-nv thanks for the make format
suggestion, that helped a lot. Thank you for the suggestions @tijyojwad @atadkase, I have tried to address all the comments, do let me know if there is any other issue.
@ahehn-nv - the checks seem to be failing due to some 500 error, could you maybe suggest what to do? Thanks!
rerun tests
There seems to be a problem with the test system. I'll take care of it and get back to you.
rerun tests
What is the best way to trigger the checks again?
Write the same comment here as I did above, or push a new commit.
But all checks have passed now.
Great! Sorry I didn't check. Thanks @ahehn-nv
@gsneha26 Welcome. :) Oh now I understand. Sorry, that comment wasn't meant for you, but for the test system to rerun its stuff. :) As I said, all checks pass now, so we just need @atadkase's approval now. :+1:
rerun tests
I think everything has been worked out. Thanks @tijyojwad @ahehn-nv @atadkase . I do not have write access to merge the commits.
Thanks for your PR, @gsneha26! I'll merge it.
Can one of the admins verify this patch?