hemalshahNV
commented
2 years ago Thanks for the heads up! We have been doing it this way ourselves and need to adjust our process too. We’ll get all of the READMEs updates soon so we don’t propagate a bad practice.
From: Hussein Ali Jaafar @.> Sent: Sunday, March 13, 2022 10:04:42 AM To: NVIDIA-ISAAC-ROS/isaac_ros_apriltag @.> Cc: Subscribed @.***> Subject: [NVIDIA-ISAAC-ROS/isaac_ros_apriltag] Updated README to avoid source and building in same terminal (PR #4)
I noticed an issue in the README which can lead to complex issues down the line.
It is bad practice to source and build a ros2 workspace in the same terminal. This is documented herehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdocs.ros.org%2Fen%2Ffoxy%2FTutorials%2FWorkspace%2FCreating-A-Workspace.html%23source-the-overlay&data=04%7C01%7Chemals%40nvidia.com%7C7b724bbe2d5d4180fa4108da051391df%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637827878853812547%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=RoTLgA%2BkW5zligUBQ6SGBOPbu8V5L7B61afBSMIitXQ%3D&reserved=0.
"It is very important that you open a new terminal, separate from the one where you built the workspace. Sourcing an overlay in the same terminal where you built, or likewise building where an overlay is sourced, may create complex issues."
You can view, comment on, or merge this pull request online at:
https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_apriltag/pull/4https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNVIDIA-ISAAC-ROS%2Fisaac_ros_apriltag%2Fpull%2F4&data=04%7C01%7Chemals%40nvidia.com%7C7b724bbe2d5d4180fa4108da051391df%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637827878853812547%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=dcYYftb9jiv%2Fwe%2FO2KcW%2Fc35XpSwaAkeu%2BFhmvCjLKE%3D&reserved=0
Commit Summary
- 440c490https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNVIDIA-ISAAC-ROS%2Fisaac_ros_apriltag%2Fpull%2F4%2Fcommits%2F440c490444a83e0a615ace5b7c65e52d9bc4c748&data=04%7C01%7Chemals%40nvidia.com%7C7b724bbe2d5d4180fa4108da051391df%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637827878853812547%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=X%2BGnvh3JochML5q89w9Myezdn15RGzA8NHAHdr2xcrI%3D&reserved=0 Updated readme to avoid source and building in same terminal
File Changes
Patch Links:
- https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_apriltag/pull/4.patchhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNVIDIA-ISAAC-ROS%2Fisaac_ros_apriltag%2Fpull%2F4.patch&data=04%7C01%7Chemals%40nvidia.com%7C7b724bbe2d5d4180fa4108da051391df%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637827878853812547%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=QEe%2FEgQ%2B8Pnfqj4LhNhBz0ismG98OWY8Bn2tKiqcU4o%3D&reserved=0
- https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_apriltag/pull/4.diffhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNVIDIA-ISAAC-ROS%2Fisaac_ros_apriltag%2Fpull%2F4.diff&data=04%7C01%7Chemals%40nvidia.com%7C7b724bbe2d5d4180fa4108da051391df%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637827878853812547%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=cjt6vV3e0%2B%2Fhu%2FDLMvwHdECzK1AN6cLkUbd33eKlNLU%3D&reserved=0
— Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNVIDIA-ISAAC-ROS%2Fisaac_ros_apriltag%2Fpull%2F4&data=04%7C01%7Chemals%40nvidia.com%7C7b724bbe2d5d4180fa4108da051391df%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637827878853812547%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=dcYYftb9jiv%2Fwe%2FO2KcW%2Fc35XpSwaAkeu%2BFhmvCjLKE%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FASS44RUPFVCHXA6BMKGZEK3U7YU3VANCNFSM5QTSUWWA&data=04%7C01%7Chemals%40nvidia.com%7C7b724bbe2d5d4180fa4108da051391df%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637827878853812547%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=A6PXqYJMFgPxihxm08uSIse4Mt%2BAZshAPWQYGm9JgHA%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7Chemals%40nvidia.com%7C7b724bbe2d5d4180fa4108da051391df%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637827878853812547%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=VXyYWZqmWbiYyfhQByNgjOEhyGLRgVkRIRCMH4x%2FpTE%3D&reserved=0 or Androidhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7Chemals%40nvidia.com%7C7b724bbe2d5d4180fa4108da051391df%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0%7C637827878853812547%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=FLqv7jJt7HEJ%2BgQMEX6%2Fct88xGVXfZg9Jt9ZU5xIQuQ%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.***>
I noticed an issue in the README which can lead to complex issues down the line.
It is bad practice to source and build a ros2 workspace in the same terminal. This is documented here.
"It is very important that you open a new terminal, separate from the one where you built the workspace. Sourcing an overlay in the same terminal where you built, or likewise building where an overlay is sourced, may create complex issues."