search

NVIDIA-ISAAC-ROS / isaac_ros_common

Common utilities, packages, scripts, Dockerfiles, and testing infrastructure for Isaac ROS packages.
https://developer.nvidia.com/isaac-ros-gems
Other
197 stars 140 forks source link

run_dev.sh always show `Error: Failed to call git rev-parse --git-dir: exit status 128` #58

Closed chitoku closed 1 year ago

chitoku commented 1 year ago

Hi,

I noticed that everytime we run run_dev.sh it shows this error message at he beginning: 

Error: Failed to call git rev-parse --git-dir: exit status 128` at the very beginning

It turns out it is coming from this line, intended to "Check if all LFS files are in place"

# Check if all LFS files are in place
LFS_FILES_STATUS=$(cd $ISAAC_ROS_DEV_DIR && git lfs ls-files | cut -d ' ' -f2)

However the $ISAAC_ROS_DEV_DIR is $HOME/workspaces/isaac_ros-dev, and you can only find git directories under ($HOME/workspaces/isaac_ros-dev/src/), so git lfs ls-files always fails.

Is this supposed to be checking the isaac_ros_common directory, like LFS_FILES_STATUS=$(cd $ISAAC_ROS_DEV_DIR/src/isaac_ros_common && git lfs ls-files | cut -d ' ' -f2)?

But I guess that's not enough to check other git directories under the src directory. Perhaps this whole block to check GIT lfs files is not neccesorry?

hemalshahNV commented 1 year ago

Thanks, @chitoku ! We have exactly this fix in an upcoming release.