NVIDIA-ISAAC-ROS / isaac_ros_object_detection

NVIDIA-accelerated, deep learned model support for image space object detection
https://developer.nvidia.com/isaac-ros-gems
Apache License 2.0
112 stars 27 forks source link

compilation error #29

Closed eladpar closed 11 months ago

eladpar commented 11 months ago

Hey , I'm trying to compile the new release. I have this error after trying to colcon build:

--- stderr: isaac_ros_nitros_correlated_timestamp_type
In file included from /workspaces/isaac_ros-dev/src/isaac_ros_nitros/isaac_ros_nitros_type/isaac_ros_nitros_correlated_timestamp_type/src/nitros_correlated_timestamp.cpp:25:
/workspaces/isaac_ros-dev/src/isaac_ros_nitros/isaac_ros_nitros_type/isaac_ros_nitros_correlated_timestamp_type/include/isaac_ros_nitros_correlated_timestamp_type/nitros_correlated_timestamp.hpp:31:10: fatal error: isaac_ros_nova_interfaces/msg/correlated_timestamp.hpp: No such file or directory
   31 | #include "isaac_ros_nova_interfaces/msg/correlated_timestamp.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

jetson xavier nx jetpack 5.0.2

kajananchinniahNV commented 11 months ago

Hi,

I was unable to reproduce this issue. Could you provide the steps you took to get this error?

Based on the error, it seems that you're missing isaac_ros_nova_interfaces, which can be found in Isaac ROS Common. Could you verify that you cloned the repository in your src folder in /workspaces/isaac_ros-dev/src ?

isaac_ros_nova_interfaces also shouldn't be a dependency for any package in this repository, so to bypass this error, you could also try to run colcon build --packages-up-to <package-name> where <package-name> would be either isaac_ros_detectnet or isaac_ros_yolov8 depending on your use case.

Hope this helps!

eladpar commented 11 months ago

Hi,

I was unable to reproduce this issue. Could you provide the steps you took to get this error?

Based on the error, it seems that you're missing isaac_ros_nova_interfaces, which can be found in Isaac ROS Common. Could you verify that you cloned the repository in your src folder in /workspaces/isaac_ros-dev/src ?

isaac_ros_nova_interfaces also shouldn't be a dependency for any package in this repository, so to bypass this error, you could also try to run colcon build --packages-up-to <package-name> where <package-name> would be either isaac_ros_detectnet or isaac_ros_yolov8 depending on your use case.

Hope this helps!

Hey you were right i had an old commit on the isaac ros common, i did git pull and now i'm running into a new problem:

--- stderr: isaac_ros_stereo_image_proc       
/workspaces/isaac_ros-dev/src/isaac_ros_image_pipeline/isaac_ros_stereo_image_proc/gxf/sgm_disparity/extensions/sgm/sgm_disparity.cpp:86:3: error: ‘VPIStereoDisparityConfidenceType’ does not name a type
   86 |   VPIStereoDisparityConfidenceType disparity_confidence_type;
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/workspaces/isaac_ros-dev/src/isaac_ros_image_pipeline/isaac_ros_stereo_image_proc/gxf/sgm_disparity/extensions/sgm/sgm_disparity.cpp: In member function ‘virtual gxf_result_t nvidia::isaac::SGMDisparity::start()’:
/workspaces/isaac_ros-dev/src/isaac_ros_image_pipeline/isaac_ros_stereo_image_proc/gxf/sgm_disparity/extensions/sgm/sgm_disparity.cpp:183:35: error: ‘struct VPIStereoDisparityEstimatorParams’ has no member named ‘confidenceType’; did you mean ‘confidenceThreshold’?
  183 |   impl_->disparity_context_params.confidenceType = (confidence_type_ == 0) ?
      |                                   ^~~~~~~~~~~~~~
      |                                   confidenceThreshold
/workspaces/isaac_ros-dev/src/isaac_ros_image_pipeline/isaac_ros_stereo_image_proc/gxf/sgm_disparity/extensions/sgm/sgm_disparity.cpp:184:5: error: ‘VPI_STEREO_CONFIDENCE_ABSOLUTE’ was not declared in this scope
  184 |     VPI_STEREO_CONFIDENCE_ABSOLUTE : VPI_STEREO_CONFIDENCE_RELATIVE;
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/workspaces/isaac_ros-dev/src/isaac_ros_image_pipeline/isaac_ros_stereo_image_proc/gxf/sgm_disparity/extensions/sgm/sgm_disparity.cpp:184:38: error: ‘VPI_STEREO_CONFIDENCE_RELATIVE’ was not declared in this scope
  184 |     VPI_STEREO_CONFIDENCE_ABSOLUTE : VPI_STEREO_CONFIDENCE_RELATIVE;
      |                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/workspaces/isaac_ros-dev/src/isaac_ros_image_pipeline/isaac_ros_stereo_image_proc/gxf/sgm_disparity/extensions/sgm/sgm_disparity.cpp:186:35: error: ‘struct VPIStereoDisparityEstimatorParams’ has no member named ‘numPasses’
  186 |   impl_->disparity_context_params.numPasses = num_passes_;
      |                                   ^~~~~~~~~
/workspaces/isaac_ros-dev/src/isaac_ros_image_pipeline/isaac_ros_stereo_image_proc/gxf/sgm_disparity/extensions/sgm/sgm_disparity.cpp:188:35: error: ‘struct VPIStereoDisparityEstimatorParams’ has no member named ‘p1’
  188 |   impl_->disparity_context_params.p1 = p1_;
      |                                   ^~
/workspaces/isaac_ros-dev/src/isaac_ros_image_pipeline/isaac_ros_stereo_image_proc/gxf/sgm_disparity/extensions/sgm/sgm_disparity.cpp:189:35: error: ‘struct VPIStereoDisparityEstimatorParams’ has no member named ‘p2’
  189 |   impl_->disparity_context_params.p2 = p2_;
      |                                   ^~
/workspaces/isaac_ros-dev/src/isaac_ros_image_pipeline/isaac_ros_stereo_image_proc/gxf/sgm_disparity/extensions/sgm/sgm_disparity.cpp:190:35: error: ‘struct VPIStereoDisparityEstimatorParams’ has no member named ‘p2Alpha’
  190 |   impl_->disparity_context_params.p2Alpha = p2_alpha_;

ke[2]: *** [gxf/sgm_disparity/CMakeFiles/gxf_sgm.dir/build.make:118: gxf/sgm_disparity/CMakeFiles/gxf_sgm.dir/extensions/sgm/sgm_disparity.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:260: gxf/sgm_disparity/CMakeFiles/gxf_sgm.dir/all] Error 2
make: *** [Makefile:146: all] Error 2
---
Failed   <<< isaac_ros_stereo_image_proc [17min 35s, exited with code 2]
kajananchinniahNV commented 11 months ago

This issue seems to stem from API changes in VPI that occurred in Jetpack 5.1.2. I noticed that you said you were on Jetpack 5.0.2, so I would recommend updating to the latest version.

Please see this issue for details https://github.com/NVIDIA-ISAAC-ROS/isaac_ros_image_pipeline/issues/40.

The system requirements for Isaac ROS packages can be found here for future reference.