search

NVIDIA-Merlin / HugeCTR

HugeCTR is a high efficiency GPU framework designed for Click-Through-Rate (CTR) estimating training
Apache License 2.0
905 stars 196 forks source link

fix: typo in kafka broker #430

Open lausannel opened 7 months ago

lausannel commented 7 months ago

While reviewing the WeChat article, I came across a subtle typographical error within the parameters of CreateSolver interface, where kafka_brokers was mistakenly referred to as kafka_brockers. Considering that this minor oversight could lead to potential confusion or implementation issues, I believe it is imperative to correct this.

Additionally, I encountered an inconsistency: in the official Python interface documentation, the CreateSolver interface does not mention a kafka_brockers parameter. This has led to some confusion, and I am seeking clarification on this matter.

bashimao commented 6 months ago

To be honest, I am aware of the problem for quite some time. I kind of ignored it to avoid compatibility problems.

I think it should be fixed.

@yingcanw Are you fine with us fixing this?