Closed radekosmulski closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
What are the changes in [01-Building-Recommender-Systems-with-Merlin.ipynb](https://github.com/NVIDIA-Merlin/Merlin/pull/1028/files#diff-ae3151beaa9bd704ff7c957b3a35394e15f72122a4746c79ea132feb02e645eb)
- I checked the diff with ReviewNB but it seems there are no changes (except of output prints). If that is the case, should we remove it from the PR?
Thank you very much for catching this, Benedikt! My bad. I have now removed the file.
This is a part of larger ongoing work that we are tracking under https://github.com/NVIDIA-Merlin/Merlin/issues/1027.
Here I am only moving the examples from
models
toMerlin
and making sure the tests run. Once this is in place, I'll work on merging a PR in models to remove the examples and clean up tests, etc.