search

NVIDIA-Merlin / Merlin

NVIDIA Merlin is an open source library providing end-to-end GPU-accelerated recommender systems, from feature engineering and preprocessing to training deep learning models and running inference in production.
Apache License 2.0
722 stars 112 forks source link

Pass a DataFrame to `setup_faiss` instead of array #1047

Closed oliverholworthy closed 1 year ago

oliverholworthy commented 1 year ago

Fixes #1042

The setup_faiss function signature changed in https://github.com/NVIDIA-Merlin/systems/pull/378 to accept a DataFrame instead of an array.

This PR updates the notebook examples/Building-and-deploying-multi-stage-RecSys/02-Deploying-multi-stage-RecSys-with-Merlin-Systems.ipynb to pass a DataFrame with the expected columns instead of the array.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

github-actions[bot] commented 1 year ago

Documentation preview

https://nvidia-merlin.github.io/Merlin/review/pr-1047

karlhigley commented 1 year ago

This was also updated in the PR that makes these notebooks use sub-graphs (which was what motivated the change in the first place) as noted on the issue re: this break, so merging this PR has created conflicts on that one. Not sure how we want to handle this in general, but it seems like we ended up in a weird state here. Might be that the change to fix the break should have been a separate PR in the first place, or could be that reviewing the PR that updates the notebook should have been a higher priority. Could go either way, but we kinda up tripping over our own shoelaces.